From: Florian Müllner <fmuellner@gnome.org>
Date: Wed, 4 Dec 2019 18:02:33 +0000 (+0100)
Subject: keyboard: Fix widget leak
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~781^2^2~339
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=ff7dfa9259fc8f9f84705b6e87318a2cf39f2c80;p=gnome-shell.git

keyboard: Fix widget leak

We currently create an extended-keys popup every time it is requested,
but only destroy it (or rather: the last one) when the keyboard itself
is destroyed.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1976
---

diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js
index a0483cc8a..0d40c8357 100644
--- a/js/ui/keyboard.js
+++ b/js/ui/keyboard.js
@@ -292,6 +292,9 @@ var Key = GObject.registerClass({
         if (this._extendedKeys.length === 0)
             return;
 
+        if (this._boxPointer)
+            return;
+
         this._boxPointer = new BoxPointer.BoxPointer(St.Side.BOTTOM);
         this._boxPointer.hide();
         Main.layoutManager.addTopChrome(this._boxPointer);